Merge pull request #4157 from smowton/smowton/cleanup/perl-regex-warning

tautschnig · web-flow · commit 4c5c3e174f7f · 2019-02-11T17:14:45.000Z
Use $1 rather than \1 to refer to regex matching group
diff --git a/regression/test.pl b/regression/test.pl
@@ -74,7 +74,7 @@ ($$$$$$$$$$)
   foreach my $key (@keys) {
     my $value = $defines->{$key};
     $options =~ s/(\$$key$|\$$key )/$value /g;
-    $options =~ s/\$$key([:;])/$value\1/g; # Variables in --classpath are separated by (semi)colons
+    $options =~ s/\$$key([:;])/$value$1/g; # Variables in --classpath are separated by (semi)colons
   }
   if (scalar @keys) {
     foreach my $word (split(/\s/, $options)) {

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ ($$$$$$$$$$)`
`74`	`74`	`foreach my $key (@keys) {`
`75`	`75`	`my $value = $defines->{$key};`
`76`	`76`	`$options =~ s/(\$$key$\|\$$key )/$value /g;`
`77`		`- $options =~ s/\$$key([:;])/$value\1/g; # Variables in --classpath are separated by (semi)colons`
	`77`	`+ $options =~ s/\$$key([:;])/$value$1/g; # Variables in --classpath are separated by (semi)colons`
`78`	`78`	`}`
`79`	`79`	`if (scalar @keys) {`
`80`	`80`	`foreach my $word (split(/\s/, $options)) {`