Fix/redirect exception handler output 3 #3952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-cs
requested review from
cesaro,
chrisr-diffblue,
cristina-david,
kroening,
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
7 tasks
added 5 commits
January 25, 2019 19:59
Getting parse_option_baset to use the same message_handlert as the rest of the application should mean that error message, especially those from default exception handlers will be formatted correctly. So, if you use --json-ui then the exception messages will be in JSON rather than just dumped on std::cerr. There is an issue with object constructors; as the message_handlert is a local variable in most programs, it is not initialised when it is passed as a reference. A comment explaining this problem is given and the issue is no worse than it already was.
This is just the reformattings required by the previous commit.
These should check that exception messages are output wrapped in JSON rather than just dumped on std::cerr.
This is a copy of an earlier patch to the CBMC tools which replaced patchy and inconsistent exception handling in each tool with the comprehensive set of catch handlers in parse_options_baset.
martin-cs
force-pushed
the
fix/redirect-exception-handler-output-3
branch
from
a1c0def to
a959df9
Compare
tautschnig
approved these changes
Jan 25, 2019
allredj
reviewed
Jan 25, 2019
There was a problem hiding this comment.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: a959df9).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98664566
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
|
Paging @peterschrammel @thk123 and @allredj as requested by the TG failure. My guess is that you need one extra argument to the constructor of |
smowton
approved these changes
Jan 26, 2019
peterschrammel
approved these changes
Jan 28, 2019
|
@peterschrammel has spoken for TestGen so ... |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #3921 / #3951 redone to use message_handlert as suggested by @tautschnig plus the corresponding updates to the Java tools as #3897 . It fixes and enables the tests in #3902 . This should reduce the risk of output, especially exceptions, winding up on std::cerr when using JSON or XML output.