Fix/redirect exception handler output #3921
Conversation
martin-cs
requested review from
chrisr-diffblue,
kroening,
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
| @@ -35,16 +35,23 @@ void parse_options_baset::help() | |||
|
|
|||
| void parse_options_baset::usage_error() | |||
| { | |||
| std::cerr << "Usage error!\n\n"; | |||
| error_message("Usage error!\n"); | |||
There was a problem hiding this comment.
Why is passing a message handler to parse_options_baset not an option, so that this would be something like log.error() << "Usage error!\n" << messaget::eom;
There was a problem hiding this comment.
Various programs inherit from both messaget and parse_option_baset. If you would prefer things like program_parse_options::program_parse_options : messaget(), parse_option_baset(*this) { ... then I can do it that way.
There was a problem hiding this comment.
Even though I strongly disagree with the inheritance done elsewhere, as far as parse_options_baset is concerned that's what I was thinking, yes. So I'd add a message_handlert &message_handler; member to parse_options_baset and then, on demand, create a messaget log(message_handler);. That way we can get away with a forward declaration of class message_handlert in parse_options.h, don't actually create unnecessary objects that we should not need under normal circumstances, and still do the output in the way desired and controlled by the caller.
There was a problem hiding this comment.
Sounds good. I'll have a go and will open a new PR.
There was a problem hiding this comment.
Hmm, I thought the difference should be fairly small?
This allows a class that inherits from parse_options_baset to override the standard direction for error messages from exception handlers so that they can be correctly formatted in JSON, XML, etc.
This means that exceptions, invariant failures, etc. will be given in the appropriate format.
These should check that exception messages are output wrapped in JSON rather than just dumped on std::cerr.
martin-cs
force-pushed
the
fix/redirect-exception-handler-output
branch
from
821bc8e to
9816337
Compare
|
Closed in favour of #3951 . |
As requested by @kroening this builds on #3897 to allow the exception handlers output to be wrapped appropriately. This enables the two test cases given in #3902 and should get us closer to not having things dumped on std:cerr when running in JSON or XML UI modes.