Skip to content

Construct side_effect_expr_nondett with a source location [blocks: #3800] #3938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2019
Merged

Construct side_effect_expr_nondett with a source location [blocks: #3800] #3938

merged 1 commit into from
Jan 28, 2019

Conversation

tautschnig
Copy link
Collaborator

Construction without a source location is deprecated.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Jan 25, 2019
@tautschnig tautschnig changed the title Construct side_effect_expr_nondett with a source location [blocks: #3800] Construct side_effect_expr_nondett with a source location [depends-on: #3933, blocks: #3800] Jan 25, 2019
tautschnig added a commit that referenced this pull request Jan 27, 2019
@tautschnig
Merge pull request #3933 from tautschnig/deprecation-function_callt
d785393 
Avoid default constructing code_function_callt [blocks: #3800, #3938]
@tautschnig
Construct side_effect_expr_nondett with a source location
27dd268 
Construction without a source location is deprecated.
@tautschnig tautschnig changed the title Construct side_effect_expr_nondett with a source location [depends-on: #3933, blocks: #3800] Construct side_effect_expr_nondett with a source location [blocks: #3800] Jan 27, 2019
allredj
allredj reviewed Jan 27, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 27dd268).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98751806

@tautschnig tautschnig merged commit 22517a3 into diffblue:develop Jan 28, 2019
@tautschnig tautschnig deleted the deprecation-nondet branch January 28, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@smowton smowton smowton approved these changes

@martin-cs martin-cs martin-cs approved these changes

@chrisr-diffblue chrisr-diffblue Awaiting requested review from chrisr-diffblue

@kroening kroening Awaiting requested review from kroening kroening is a code owner

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@pkesseli pkesseli Awaiting requested review from pkesseli

Assignees

@peterschrammel peterschrammel

@martin-cs martin-cs

@chrisr-diffblue chrisr-diffblue

Labels
blocker cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tautschnig @smowton @martin-cs @allredj @peterschrammel @chrisr-diffblue