Skip to content

Avoid default constructing code_function_callt [blocks: #3800, #3938] #3933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2019

Conversation

tautschnig
Copy link
Collaborator

Construct them bottom-up, which is more efficient and type safe.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig changed the title Avoid default constructing code_function_callt [blocks: #3800] Avoid default constructing code_function_callt [blocks: #3800, #3938] Jan 25, 2019
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: f882bbf).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98599935
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

@tautschnig tautschnig force-pushed the deprecation-function_callt branch from f882bbf to 65af30b Compare January 26, 2019 13:13

// do some type adjustment for the arguments,
// as Java promotes arguments
// Also cast pointers since intermediate locals
// can be void*.

INVARIANT(
parameters.size() <= arguments.size(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Java I'm 99% certain this can be ==, as Java varargs are syntactic sugar for an Object[] parameter

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was assuming so, but that's stronger than what was asserted before so I tried not to silently sneak in that change. Will add it now, though :-)

Construct them bottom-up, which is more efficient and type safe.
@tautschnig tautschnig force-pushed the deprecation-function_callt branch from 65af30b to 9976eca Compare January 26, 2019 18:22
@tautschnig tautschnig assigned martin-cs and unassigned smowton and kroening Jan 26, 2019
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 9976eca).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98716961

@tautschnig tautschnig merged commit d785393 into diffblue:develop Jan 27, 2019
@tautschnig tautschnig deleted the deprecation-function_callt branch January 27, 2019 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants