-
Notifications
You must be signed in to change notification settings - Fork 274
Avoid default constructing code_function_callt [blocks: #3800, #3938] #3933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid default constructing code_function_callt [blocks: #3800, #3938] #3933
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: f882bbf).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98599935
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
f882bbf
to
65af30b
Compare
|
||
// do some type adjustment for the arguments, | ||
// as Java promotes arguments | ||
// Also cast pointers since intermediate locals | ||
// can be void*. | ||
|
||
INVARIANT( | ||
parameters.size() <= arguments.size(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Java I'm 99% certain this can be ==
, as Java varargs are syntactic sugar for an Object[] parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was assuming so, but that's stronger than what was asserted before so I tried not to silently sneak in that change. Will add it now, though :-)
Construct them bottom-up, which is more efficient and type safe.
65af30b
to
9976eca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 9976eca).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98716961
Construct them bottom-up, which is more efficient and type safe.