-
Notifications
You must be signed in to change notification settings - Fork 274
Update CATCH to version 2.5.0 #3896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: 4f780a3).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98209867
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
Downloaded via https://github.com/catchorg/Catch2/releases/download/v2.5.0/catch.hpp Version 2 also addresses the only local change we ever had, which was adding "const &" to the exception type.
4f780a3
to
02fe307
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: 02fe307).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98331058
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
@allredj @peterschrammel @thk123 This seems to continue to trip up TG. I'm not actually sure why, though. Could you please take a look? |
@tautschnig Looks like this one also needs a manual bump. Will look at this tomorrow. |
@tautschnig |
Thanks a lot @allredj!! |
Downloaded via
https://github.com/catchorg/Catch2/releases/download/v2.5.0/catch.hpp
Version 2 also addresses the only local change we ever had, which was adding
"const &" to the exception type.