Skip to content

Update CATCH to version 2.5.0 #3896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Conversation

tautschnig
Copy link
Collaborator

Downloaded via
https://github.com/catchorg/Catch2/releases/download/v2.5.0/catch.hpp

Version 2 also addresses the only local change we ever had, which was adding
"const &" to the exception type.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 4f780a3).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98209867
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

Downloaded via
https://github.com/catchorg/Catch2/releases/download/v2.5.0/catch.hpp

Version 2 also addresses the only local change we ever had, which was adding
"const &" to the exception type.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 02fe307).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98331058
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

@tautschnig
Copy link
Collaborator Author

@allredj @peterschrammel @thk123 This seems to continue to trip up TG. I'm not actually sure why, though. Could you please take a look?

@allredj
Copy link
Contributor

allredj commented Jan 23, 2019

@tautschnig Looks like this one also needs a manual bump. Will look at this tomorrow.

@allredj
Copy link
Contributor

allredj commented Jan 24, 2019

@allredj
Copy link
Contributor

allredj commented Jan 24, 2019

@tautschnig
TG bump passing. Can be merged.

@tautschnig tautschnig merged commit 1e5f423 into diffblue:develop Jan 24, 2019
@tautschnig tautschnig deleted the update-catch branch January 24, 2019 14:44
@tautschnig
Copy link
Collaborator Author

Thanks a lot @allredj!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants