Skip to content

Remove (unused) langapi dependency from solvers/ #3734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2019

Conversation

tautschnig
Copy link
Collaborator

The code using from_expr was disabled via #if 0. Now the code is removed and the dependency can be dropped.

This currently includes commits from #3711, which thus needs to go in first.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Jan 9, 2019
@tautschnig tautschnig changed the title Remove (unused) langapi dependency from solvers/ [depends: #3711] Remove (unused) langapi dependency from solvers/ [depends-on: #3711] Jan 9, 2019
@smowton
Copy link
Contributor

smowton commented Jan 9, 2019

Don't forget cmake

@tautschnig
Copy link
Collaborator Author

Don't forget cmake

I checked, but at least I didn't spot anything to be done in there.

Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so there isn't

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 19e4ddf).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96762983
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

peterschrammel added a commit that referenced this pull request Jan 10, 2019
Move {json,xml}_expr.{h,cpp} to goto-programs [blocks: #3734, #3736]
The code using from_expr was disabled via #if 0. Now the code is removed and the
dependency can be dropped.
@tautschnig tautschnig changed the title Remove (unused) langapi dependency from solvers/ [depends-on: #3711] Remove (unused) langapi dependency from solvers/ Jan 10, 2019
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: e78372e).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96948931
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

@tautschnig tautschnig merged commit 4d4596d into diffblue:develop Jan 11, 2019
@tautschnig tautschnig deleted the solvers-no-langapi branch January 11, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants