-
Notifications
You must be signed in to change notification settings - Fork 273
Move {json,xml}_expr.{h,cpp} to goto-programs [blocks: #3734, #3736] #3711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move {json,xml}_expr.{h,cpp} to goto-programs [blocks: #3734, #3736] #3711
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: e6d5e21).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96535289
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: bf25f8d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96539054
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
I suspect this requires a genuine update in TG as quite possibly it uses |
bf25f8d
to
833721d
Compare
@tautschnig It does look like this needs a TG update, I'm working on it and I'll keep you updated. |
This prepares the move of {json,xml}_expr.{h,cpp} to goto-programs to remove the dependency of util on langapi.
There should not be a dependency from util to langapi, and goto-programs is also the only place where {json,xml}_expr are used.
833721d
to
d8b511f
Compare
Thank you @antlechner! I have rebased this PR to hopefully simplify the TG work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: 833721d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96755542
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: d8b511f).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96772500
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
@tautschnig We have a TG pointer bump that passes now, so feel free to merge this PR. Thanks for notifying us that an update was needed. 🙂 |
Thanks @antlechner! Re-assigning to @kroening and @peterschrammel for review. |
This prepares the move of {json,xml}_expr.{h,cpp} to goto-programs to remove the
dependency of util on langapi.