Skip to content

C++ front-end: Distinguish references from rvalue references [blocks: #3659] #3674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2019

Conversation

tautschnig
Copy link
Collaborator

Template specialisation previously would produce the same symbol name for both
template struct S<T&> as well as template struct S<T&&>.
As Visual Studio uses both of these in system headers, any test involving
includes failed on Windows.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 2de7fec).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96299455
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

@tautschnig tautschnig changed the title C++ front-end: Distinguish references from rvalue references C++ front-end: Distinguish references from rvalue references [blocks: #3659] Jan 4, 2019
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 25ee99d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96320982

Template specialisation previously would produce the same symbol name for both
template<typename T> struct S<T&> as well as template<typename T> struct S<T&&>.
As Visual Studio uses both of these in system headers, any test involving
includes failed on Windows.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: f9b9e05).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96873547

@tautschnig tautschnig merged commit 396794c into diffblue:develop Jan 10, 2019
@tautschnig tautschnig deleted the c++-rvalue branch January 10, 2019 18:22
tautschnig added a commit that referenced this pull request Jan 11, 2019
Include goto-cl regression tests in test sequence [depends-on: #3674]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants