C++ front-end: Distinguish references from rvalue references

Template specialisation previously would produce the same symbol name for both
template<typename T> struct S<T&> as well as template<typename T> struct S<T&&>.
As Visual Studio uses both of these in system headers, any test involving
includes failed on Windows.

Author: tautschnig

buildspec-windows.yml

@@ -47,10 +47,7 @@ phases:
         Remove-Item cbmc\byte_update5 -Force -Recurse
         Remove-Item cbmc\byte_update6 -Force -Recurse
         Remove-Item cbmc\byte_update7 -Force -Recurse
-        Remove-Item cpp -Force -Recurse
-        Remove-Item cbmc-cpp -Force -Recurse
-        Remove-Item goto-gcc -Force -Recurse
-        Remove-Item systemc -Force -Recurse
+        Remove-Item cpp\virtual1 -Force -Recurse
         cd ..
         cd jbmc/regression
         Remove-Item jbmc\VarLengthArrayTrace1 -Force -Recurse

src/cpp/cpp_type2name.cpp

@@ -33,7 +33,18 @@ static void irep2name(const irept &irep, std::string &result)
   if(is_reference(static_cast<const typet&>(irep)))
     result+="reference";
 
-  if(irep.id()!="")
+  if(is_rvalue_reference(static_cast<const typet &>(irep)))
+    result += "rvalue_reference";
+
+  if(irep.id() == ID_frontend_pointer)
+  {
+    if(irep.get_bool(ID_C_reference))
+      result += "reference";
+
+    if(irep.get_bool(ID_C_rvalue_reference))
+      result += "rvalue_reference";
+  }
+  else if(!irep.id().empty())
     result+=do_prefix(irep.id_string());
 
   if(irep.get_named_sub().empty() && irep.get_sub().empty())