Silence Visual Studio warnings for generated or lexer/parser code [blocks: #2310, #2551] #3425

tautschnig · 2018-11-15T09:04:46Z

There is very little we can do about those warnings.

Each commit message has a non-empty body, explaining why the change was made.
n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
n/a My commit message includes data points confirming performance improvements (if claimed).
My PR is restricted to a single feature or bugfix.
n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

smowton · 2018-11-15T10:39:25Z

Should these all be push/pop'd so as to scope them to just the generated code, not anyone including them? (Or do they not generate header files?)

smowton · 2018-11-15T10:41:53Z

Nitpick: to avoid the Catch changes getting thrown away whenever we upgrade to the latest Catch version, how about introducing an intermediate header (say use_catch.h) that configures warnings appropriately then includes the actual catch.hpp, which should never be used directly and should be left exactly matching the shipped version?

tautschnig · 2018-12-01T12:39:32Z

Should these all be push/pop'd so as to scope them to just the generated code, not anyone including them? (Or do they not generate header files?)

I have just checked: no, these do not end up in generated header files used by non-generated code, just in the generated lexer and parser.

tautschnig · 2018-12-01T12:41:00Z

Nitpick: to avoid the Catch changes getting thrown away whenever we upgrade to the latest Catch version, how about introducing an intermediate header (say use_catch.h) that configures warnings appropriately then includes the actual catch.hpp, which should never be used directly and should be left exactly matching the shipped version?

This is now done. I might actually put together a separate PR actually updating the header file, the one GCC-8 related local fix that we have has been addressed in Catch 2.x.

This change, however, did considerable increase the size of this PR, please review commit-by-commit.

allredj

✔️
Passed Diffblue compatibility checks (cbmc commit: b606e41).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/93273944

Ensure proper dependencies on json.dir [blocks: #3425]

Add missing module_dependencies.txt files [blocks: #3425]

allredj

✔️
Passed Diffblue compatibility checks (cbmc commit: db38a2a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/93282606

allredj

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 0c392b2).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96191957
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

the cbmc commit has disappeared in the mean time (e.g. in a force-push)
the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

allredj

🚫
This PR failed Diffblue compatibility checks (cbmc commit: abc4253).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96203327
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

the cbmc commit has disappeared in the mean time (e.g. in a force-push)
the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

allredj

🚫
This PR failed Diffblue compatibility checks (cbmc commit: d678150).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/96283008
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

the cbmc commit has disappeared in the mean time (e.g. in a force-push)
the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

Silence warnings resulting from catch.hpp [blocks: #2310, #3425]

tautschnig · 2019-01-23T19:59:16Z

This PR is now restricted to just silencing warnings in flex/bison generated code.

allredj

✔️
Passed Diffblue compatibility checks (cbmc commit: 39c4ebb).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98387964

owen-mc-diffblue · 2019-01-28T13:47:53Z

It's a bit weird having the comments below the thing that they explain - the normal convention is to do the opposite

tautschnig · 2019-01-30T18:29:19Z

It's a bit weird having the comments below the thing that they explain - the normal convention is to do the opposite

Ack, I'm not actually sure why I had done it that way. I've fixed this now.

allredj

✔️
Passed Diffblue compatibility checks (cbmc commit: ffe36ab).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99182850

…on in lexer Flex generates definitions before system headers are included, and tokens result in signed/unsigned comparison.

allredj

⚠️
This PR failed Diffblue compatibility checks (cbmc commit: c3d3b6a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/104501738
Status will be re-evaluated on next push.
Common spurious failures:

the cbmc commit has disappeared in the mean time (e.g. in a force-push)
the author is not in the list of contributors (e.g. first-time contributors).
the compatibility was already broken by an earlier merge.

tautschnig added Build blocker labels Nov 15, 2018

tautschnig requested review from chrisr-diffblue, kroening, peterschrammel and smowton as code owners November 15, 2018 09:04

tautschnig changed the title ~~Silence Visual Studio warnings for generated or imported code~~ Silence Visual Studio warnings for generated or imported code [blocks: #2310] Nov 15, 2018

tautschnig changed the title ~~Silence Visual Studio warnings for generated or imported code [blocks: #2310]~~ Silence Visual Studio warnings for generated or imported code [blocks: #2310, #2551] Nov 15, 2018

tautschnig self-assigned this Nov 15, 2018

tautschnig force-pushed the vs-silence-generated branch from eb3dbf3 to 36e2aed Compare December 1, 2018 12:40

tautschnig assigned smowton, kroening, peterschrammel and chrisr-diffblue and unassigned tautschnig Dec 1, 2018

tautschnig force-pushed the vs-silence-generated branch 3 times, most recently from a8bbe9d to b606e41 Compare December 2, 2018 10:32

allredj reviewed Dec 2, 2018

View reviewed changes

tautschnig added a commit that referenced this pull request Dec 2, 2018

Merge pull request #3499 from tautschnig/build-deps

0841199

Ensure proper dependencies on json.dir [blocks: #3425]

tautschnig added a commit that referenced this pull request Dec 2, 2018

Merge pull request #3498 from tautschnig/missing-module-deps

4415578

Add missing module_dependencies.txt files [blocks: #3425]

tautschnig force-pushed the vs-silence-generated branch from b606e41 to db38a2a Compare December 2, 2018 14:58

allredj reviewed Dec 2, 2018

View reviewed changes

smowton approved these changes Dec 3, 2018

View reviewed changes

tautschnig unassigned smowton and chrisr-diffblue Dec 3, 2018

tautschnig force-pushed the vs-silence-generated branch from 0c392b2 to abc4253 Compare January 3, 2019 14:11

allredj reviewed Jan 3, 2019

View reviewed changes

tautschnig force-pushed the vs-silence-generated branch from abc4253 to d678150 Compare January 4, 2019 09:54

peterschrammel assigned kroening and unassigned thk123, kroening, peterschrammel and allredj Jan 4, 2019

allredj reviewed Jan 4, 2019

View reviewed changes

tautschnig mentioned this pull request Jan 21, 2019

Silence warnings resulting from catch.hpp [blocks: #2310, #3425] #3876

Merged

3 tasks

tautschnig force-pushed the vs-silence-generated branch from d678150 to 780989f Compare January 21, 2019 18:31

thk123 pushed a commit that referenced this pull request Jan 22, 2019

Merge pull request #3876 from tautschnig/catch-warnings

9a6465b

Silence warnings resulting from catch.hpp [blocks: #2310, #3425]

tautschnig force-pushed the vs-silence-generated branch 2 times, most recently from 237ad7f to 39c4ebb Compare January 23, 2019 19:57

tautschnig changed the title ~~Silence Visual Studio warnings for generated or imported code [blocks: #2310, #2551]~~ Silence Visual Studio warnings for generated or lexer/parser code [blocks: #2310, #2551] Jan 23, 2019

allredj reviewed Jan 23, 2019

View reviewed changes

tautschnig force-pushed the vs-silence-generated branch from 39c4ebb to ffe36ab Compare January 30, 2019 18:29

allredj reviewed Jan 30, 2019

View reviewed changes

owen-mc-diffblue approved these changes Jan 31, 2019

View reviewed changes

tautschnig added 2 commits March 14, 2019 20:46

Silence Visual Studio warnings in generated parser code

3c32a36

Visual Studio: silence warning about macro re-definition and conversi…

c3d3b6a

…on in lexer Flex generates definitions before system headers are included, and tokens result in signed/unsigned comparison.

tautschnig force-pushed the vs-silence-generated branch from ffe36ab to c3d3b6a Compare March 14, 2019 20:46

allredj reviewed Mar 14, 2019

View reviewed changes

kroening approved these changes Apr 24, 2019

View reviewed changes

kroening merged commit 626ec18 into diffblue:develop Apr 24, 2019

tautschnig deleted the vs-silence-generated branch April 24, 2019 10:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Silence Visual Studio warnings for generated or lexer/parser code [blocks: #2310, #2551] #3425

Silence Visual Studio warnings for generated or lexer/parser code [blocks: #2310, #2551] #3425

Uh oh!

tautschnig commented Nov 15, 2018

Uh oh!

smowton commented Nov 15, 2018

Uh oh!

smowton commented Nov 15, 2018

Uh oh!

tautschnig commented Dec 1, 2018

Uh oh!

tautschnig commented Dec 1, 2018 •

edited

Loading

Uh oh!

allredj left a comment

Uh oh!

allredj left a comment

Uh oh!

allredj left a comment

Uh oh!

allredj left a comment

Uh oh!

allredj left a comment

Uh oh!

tautschnig commented Jan 23, 2019

Uh oh!

allredj left a comment

Uh oh!

owen-mc-diffblue commented Jan 28, 2019

Uh oh!

tautschnig commented Jan 30, 2019

Uh oh!

allredj left a comment

Uh oh!

allredj left a comment

Uh oh!

Uh oh!

Silence Visual Studio warnings for generated or lexer/parser code [blocks: #2310, #2551] #3425

Silence Visual Studio warnings for generated or lexer/parser code [blocks: #2310, #2551] #3425

Uh oh!

Conversation

tautschnig commented Nov 15, 2018

Uh oh!

smowton commented Nov 15, 2018

Uh oh!

smowton commented Nov 15, 2018

Uh oh!

tautschnig commented Dec 1, 2018

Uh oh!

tautschnig commented Dec 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

tautschnig commented Jan 23, 2019

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

owen-mc-diffblue commented Jan 28, 2019

Uh oh!

tautschnig commented Jan 30, 2019

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

allredj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tautschnig commented Dec 1, 2018 •

edited

Loading