Skip to content

Ensure proper dependencies on json.dir [blocks: #3425] #3499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2018

Conversation

tautschnig
Copy link
Collaborator

json-symtab will always add a dependency on json, and we had depended on json in
goto-cc for a while already. It seems just by chance that we didn't see any
build failures up until today.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

json-symtab will always add a dependency on json, and we had depended on json in
goto-cc for a while already. It seems just by chance that we didn't see any
build failures up until today.
@tautschnig tautschnig changed the title Ensure proper dependencies on json.dir Ensure proper dependencies on json.dir [blocks: #3425] Dec 2, 2018
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 5acf676).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/93274053

@tautschnig tautschnig merged commit 0841199 into diffblue:develop Dec 2, 2018
@tautschnig tautschnig deleted the build-deps branch December 2, 2018 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants