complete constructors for function_application_exprt #3048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
requested review from
peterschrammel,
pkesseli and
smowton
as code owners
7 tasks
tautschnig
approved these changes
Sep 26, 2018
smowton
approved these changes
Sep 26, 2018
tautschnig
force-pushed
the
function_application_exprt-constructors
branch
from
88a6af8 to
bf11b2d
Compare
kroening
requested review from
cesaro,
cristina-david,
martin-cs,
mgudemann,
NathanJPhillips and
thk123
as code owners
peterschrammel
approved these changes
Sep 26, 2018
src/util/std_expr.h
Outdated
| const symbol_exprt &_function, | ||
| const argumentst &_arguments, | ||
| const typet &_type) | ||
| : binary_exprt(ID_function_application, _type) // NOLINT(runtime/explicit) |
There was a problem hiding this comment.
The NOLINT comment doesn't seem necessary anymore.
tautschnig
force-pushed
the
function_application_exprt-constructors
branch
3 times, most recently
from
ec68b3b to
ade7a78
Compare
allredj
reviewed
Sep 26, 2018
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: ec68b3b).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85996359
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
allredj
reviewed
Sep 26, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: ade7a78).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86003046
This fosters RIAA and avoids using the deprecated symbol_exprt() constructor.
tautschnig
force-pushed
the
function_application_exprt-constructors
branch
from
ade7a78 to
df1ee1c
Compare
allredj
reviewed
Sep 26, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: df1ee1c).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86044590
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a problem uncovered by PR #3045.