complete constructors for function_application_exprt

Author: Daniel Kroening

src/goto-programs/builtin_functions.cpp

@@ -900,11 +900,7 @@ void goto_convertt::do_function_call_symbol(
     if(lhs.is_nil())
       return;
 
-    function_application_exprt rhs;
-    rhs.type()=lhs.type();
-    rhs.add_source_location()=function.source_location();
-    rhs.function()=function;
-    rhs.arguments()=arguments;
+    function_application_exprt rhs(function, arguments, lhs.type());
 
     code_assignt assignment(lhs, rhs);
     assignment.add_source_location()=function.source_location();

src/util/std_expr.h

@@ -4333,22 +4333,16 @@ class null_pointer_exprt:public constant_exprt
 class function_application_exprt:public binary_exprt
 {
 public:
-  function_application_exprt():binary_exprt(ID_function_application)
-  {
-    op0()=symbol_exprt();
-  }
-
-  explicit function_application_exprt(const typet &_type):
-    binary_exprt(ID_function_application, _type)
-  {
-    op0()=symbol_exprt();
-  }
+  using argumentst = exprt::operandst;
 
   function_application_exprt(
-    const symbol_exprt &_function, const typet &_type):
-      function_application_exprt(_type) // NOLINT(runtime/explicit)
+    const symbol_exprt &_function,
+    const argumentst &_arguments,
+    const typet &_type)
+    : binary_exprt(ID_function_application, _type) // NOLINT(runtime/explicit)
   {
     function()=_function;
+    arguments() = _arguments;
   }
 
   symbol_exprt &function()
@@ -4361,8 +4355,6 @@ class function_application_exprt:public binary_exprt
     return static_cast<const symbol_exprt &>(op0());
   }
 
-  typedef exprt::operandst argumentst;
-
   argumentst &arguments()
   {
     return op1().operands();