move version.h to util/ #2500
Merged
move version.h to util/ #2500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
requested review from
chrisr-diffblue,
peterschrammel and
smowton
as code owners
kroening
force-pushed
the
git-version-speedup
branch
from
1621586 to
ca09cea
Compare
tautschnig
requested changes
Jul 2, 2018
|
@tautschnig the version file is the same for each program that uses it, right? If so should we simply make it out of the |
|
Yes, the file is the same for anything built out of this source tree. My concern is the cross-directory build rule that |
|
Ok, let's go for util/version.h, made by all |
kroening
force-pushed
the
git-version-speedup
branch
from
ca09cea to
f57e2f6
Compare
kroening
force-pushed
the
git-version-speedup
branch
from
f57e2f6 to
a99875b
Compare
kroening
changed the title
kroening
force-pushed
the
git-version-speedup
branch
from
a99875b to
2f3a4af
Compare
tautschnig
approved these changes
Jul 3, 2018
kroening
force-pushed
the
git-version-speedup
branch
2 times, most recently
from
d4ae346 to
6930227
Compare
kroening
force-pushed
the
git-version-speedup
branch
from
6930227 to
b96c7ba
Compare
allredj
reviewed
Jul 3, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: b96c7ba).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/77996025
smowton
approved these changes
Jul 4, 2018
NathanJPhillips
pushed a commit
to NathanJPhillips/cbmc
that referenced
this pull request
Aug 22, 2018
6409eae Merge pull request diffblue#2449 from tautschnig/c++-template-cleanup 1134455 Merge pull request diffblue#2443 from tautschnig/vs-rdecl 6e9e655 Merge pull request diffblue#2520 from smowton/smowton/feature/constant-propagator-selectivity 9013779 Merge pull request diffblue#2383 from tautschnig/no-sed 56a487e Constant propagator: add callback to filter tracked values a354513 Merge pull request diffblue#2510 from polgreen/hex_trace 3545be4 Merge pull request diffblue#2523 from peterschrammel/do-not-ignore-full-slice 819c683 Merge pull request diffblue#2493 from jeannielynnmoulton/jeannie/InnerClasses a018652 allow unsigned long instead of unsigned in regression test for hex_trace d5bbdd8 represent numerical values in CBMC trace in hex 19bddce Do not ignore --full-slice 5350133 Refactor inner class parsing. 6e554d9 Merge pull request diffblue#2500 from diffblue/git-version-speedup 9ba55e2 Marks anonymous classes as inner classes b96c7ba move build commands for version.h from common to util/ 6ce7b13 Clarifies language in documentation. c0c1029 Fixes parsing for anonymous classes 1930aef Refactors parsing of inner classes attribute. b28562b Adds unit test for parsing inner classes. c336455 Stores inner class data in java class types. 457bac9 Parses InnerClasses attribute of java bytecode. 34bd58f Clean up unused template instantiation symbols fea1f47 Remove unused parameter from rDeclarator e00c6ee Set BUILD_ENV via make variable instead of patching via sed git-subtree-dir: cbmc git-subtree-split: 6409eae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up 'make' on my laptop from 3.0s to 0.6s.
It is unclear whether the same can be done with cmake.