Set BUILD_ENV via make variable instead of patching via sed #2383
Conversation
tautschnig
requested review from
chrisr-diffblue,
forejtv,
kroening,
peterschrammel,
smowton and
thk123
as code owners
|
Is setting I confess that I don't know what |
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: e00c6ee).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/76947100
|
On Windows, there is a choice of two build systems: You can build with a MingW g++, or with Visual Studio. AUTO selects the MingW path right now, but practically we deliver binaries built with Visual Studio. Perhaps the default should simply change to Visual Studio. |
As far as I am aware there still is a customer using MinGW? I'd say this switch is something we could do for a 6.0 release, but we need to take note of it in the release notes. Also, I'd rather do this in a separate pull request. This PR really just changes our CI scripts, it has no customer impact. |
|
Re customers using WinGW - yes, there are customers out there using it (I've just returned from visiting one of them...) |
6409eae Merge pull request diffblue#2449 from tautschnig/c++-template-cleanup 1134455 Merge pull request diffblue#2443 from tautschnig/vs-rdecl 6e9e655 Merge pull request diffblue#2520 from smowton/smowton/feature/constant-propagator-selectivity 9013779 Merge pull request diffblue#2383 from tautschnig/no-sed 56a487e Constant propagator: add callback to filter tracked values a354513 Merge pull request diffblue#2510 from polgreen/hex_trace 3545be4 Merge pull request diffblue#2523 from peterschrammel/do-not-ignore-full-slice 819c683 Merge pull request diffblue#2493 from jeannielynnmoulton/jeannie/InnerClasses a018652 allow unsigned long instead of unsigned in regression test for hex_trace d5bbdd8 represent numerical values in CBMC trace in hex 19bddce Do not ignore --full-slice 5350133 Refactor inner class parsing. 6e554d9 Merge pull request diffblue#2500 from diffblue/git-version-speedup 9ba55e2 Marks anonymous classes as inner classes b96c7ba move build commands for version.h from common to util/ 6ce7b13 Clarifies language in documentation. c0c1029 Fixes parsing for anonymous classes 1930aef Refactors parsing of inner classes attribute. b28562b Adds unit test for parsing inner classes. c336455 Stores inner class data in java class types. 457bac9 Parses InnerClasses attribute of java bytecode. 34bd58f Clean up unused template instantiation symbols fea1f47 Remove unused parameter from rDeclarator e00c6ee Set BUILD_ENV via make variable instead of patching via sed git-subtree-dir: cbmc git-subtree-split: 6409eae
No description provided.