Unit tests for simplify expression #1075
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The linting error relates to #1038 |
tautschnig
requested changes
Jul 3, 2017
There was a problem hiding this comment.
The question is should a type cast from an integral type to an integral type, where the destination is >= the source (e.g. casting from a 32 bit signed integer to a 64 bit signed integer), should the typecast be removed?
No, not in general. See the comments at the beginning of this branch of the code, which in particular mention overflow.
For constants the story is a different one, but this is already handled further down below in that function.
thk123
commented
Jul 3, 2017
| WHEN("Simplifying a[(signed long int)0]") | ||
| { | ||
| exprt out_expr; | ||
| bool success=language.to_expr("a[(signed long int)0]", "", out_expr, ns); |
There was a problem hiding this comment.
This isn't a success flag, but a failed flag.
5 tasks
|
Replaced by #5229 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure the change is correct - but either way we should have unit tests that verify the behaviour so it is documented.
The question is should a type cast from an integral type to an integral type, where the destination is >= the source (e.g. casting from a 32 bit signed integer to a 64 bit signed integer), should the typecast be removed?
These unit tests verify that they should, but currently they are not. The commit thk123@c6387e9 means that they are.
Found this trying to fix a different bug but this turned out to be unrelated.