Skip to content

Fix removal of first component #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2017
Merged

Fix removal of first component #1038

merged 1 commit into from
Jul 3, 2017

Conversation

pkesseli
Copy link
Contributor

Removal of first component for header guard suggestion is hard-coded to
remove 4 characters ("src/"). This doesn't work with all directory
names ("unit/").

@peterschrammel peterschrammel requested a review from thk123 June 25, 2017 15:24
Copy link
Contributor

@thk123 thk123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused why this is failing on AppVeyor, though clearly unrelated to this change. Might be worth a rebase?

Removal of first component for header guard suggestion is hard-coded to
remove 4 characters ("src/").  This doesn't work with all directory
names ("unit/").
@pkesseli
Copy link
Contributor Author

Rebased @thk123 @peterschrammel.

Copy link
Contributor

@thk123 thk123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkesseli thanks - it is now passing AppVeyor so yay!

@kroening kroening merged commit 3c896fd into diffblue:master Jul 3, 2017
@pkesseli pkesseli deleted the cpplint/header-guard-first-component branch July 12, 2017 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants