Try using yargs instead of optimist #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

gurdiga wants to merge 1 commit into db-migrate:master from gurdiga:replace-optimist-with-yargs

gurdiga commented Mar 29, 2020 •

edited

Loading

Fixes #224.

Summary

I’m stuck because npm test fails with this error:

ENOENT: no such file or directory, scandir '/Users/vlad/tmp/node-db-migrate/test/integration/migrations'
      at Object.fs.readdirSync (fs.js:921:18)
      at ChildProcess.<anonymous> (/Users/vlad/tmp/node-db-migrate/test/integration/create_test.js:326:32)
      at ChildProcess.emit (events.js:180:13)
      at ChildProcess.emit (domain.js:440:23)
      at Process.ChildProcess._handle.onexit (internal/child_process.js:209:12)

There were 1 test script error(s).
[...many lines later...]
22 of 82 tests failed

I have tried to create that missing directory, but when I run npm test it seems to remove it and then fail again. 🤔

I’m seeing a Travis CI build build step ran for the PR 584, and not seeing it for this PR. — I’m wondering what am I missing. 🤔

Environment

node v9.11.1 and npm v6.4.1 through NVM.
macOS 10.15.4 (19E266)

commitlint-wzrdtales bot commented Mar 29, 2020

There were the following issues with this Pull Request

Commit: 0fc7a9b
- ✖ message may not be empty
  , - ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

commitlint-wzrdtales bot commented Mar 29, 2020

There were the following issues with this Pull Request

Commit: e136a5f
- ✖ message may not be empty
  , - ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

commitlint-wzrdtales bot commented Mar 29, 2020

There were the following issues with this Pull Request

Commit: 3a17e05
- ✖ message may not be empty
  , - ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

commitlint-wzrdtales bot commented Mar 29, 2020

There were the following issues with this Pull Request

Commit: 1a49923
- ✖ message may not be empty
  , - ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

commitlint-wzrdtales bot commented Mar 29, 2020

There were the following issues with this Pull Request

Commit: 5241de8
- ✖ message may not be empty
  , - ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!


          fix(dependencies): replace optimist with yargs

12f153e

This is me poking at the issue of optimits not being maintained any
more[0] and having the security issue because of minimist[1]. I’m not
sure it’s going to be yargs in the end, it’s just what optimits
developer recommends as an alternative.

[0]: https://www.npmjs.com/package/optimist
[1]: https://www.npmjs.com/advisories/1179

Signed-off-by: Vlad GURDIGA <[email protected]>

gurdiga changed the title ~~Try using yargs instead of optimits~~ Try using yargs instead of optimist

Member

wzrdtales commented Mar 29, 2020

Thank you for your effort. https://travis-ci.org/github/db-migrate/node-db-migrate/jobs/668333555

we will need to have look what is failing there right now, seems it is not 100% compatible.

wzrdtales mentioned this pull request

vulnerability in Optimist #674

Closed

Member

wzrdtales commented Apr 8, 2020

closed in favour of #674

wzrdtales closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet