Skip to content

Commit 1a49923

Browse files
committed
Try using yargs instead of optimits
This is me poking at the issue of optimits not being maintained any more[0] and having the security issue because of minimist[1]. I’m not sure it’s going to be yargs in the end, it’s just what optimits developer recommends as an alternative. [0]: https://www.npmjs.com/package/optimist [1]: https://www.npmjs.com/advisories/1179 Signed-off-by: Vlad GURDIGA <[email protected]>
1 parent 4caaf39 commit 1a49923

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

lib/commands/run.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22

33
var log = require('db-migrate-shared').log;
4-
var optimist = require('optimist');
4+
var argParser = require('yargs');
55
var load = require('./');
66
var transition = load('transition');
77

@@ -117,7 +117,7 @@ function run (internals, config) {
117117
'Invalid Action: Must be [up|down|check|create|reset|sync|' +
118118
'db|transition].'
119119
);
120-
optimist.showHelp();
120+
argParser.showHelp();
121121
process.exit(1);
122122
}
123123
break;

lib/commands/set-default-argv.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var optimist = require('optimist');
1+
var argParser = require('yargs');
22
var log = require('db-migrate-shared').log;
33

44
module.exports = function (internals, isModule) {
@@ -20,7 +20,7 @@ module.exports = function (internals, isModule) {
2020
};
2121

2222
if (!isModule) {
23-
internals.argv = optimist
23+
internals.argv = argParser
2424
.default(defaultConfig)
2525
.usage(
2626
'Usage: db-migrate [up|down|check|reset|sync|create|db|transition] ' +
@@ -110,7 +110,8 @@ module.exports = function (internals, isModule) {
110110
.describe('ignore-completed-migrations', 'Start at the first migration')
111111
.boolean('ignore-completed-migrations')
112112
.describe('log-level', 'Set the log-level, for example sql|warn')
113-
.string('log-level');
113+
.string('log-level')
114+
.parse();
114115
} else {
115116
const _internalsArgv = Object.assign(defaultConfig, internals.cmdOptions);
116117
internals.argv = {
@@ -128,7 +129,7 @@ module.exports = function (internals, isModule) {
128129
plugin.forEach(function (plugin) {
129130
// var configs = plugin['init:cli:config:hook']();
130131
// if (!configs) return;
131-
// hook not yet used, we look into migrating away from optimist first
132+
// hook not yet used, we look into migrating away from argParser first
132133
});
133134
}
134135

@@ -142,7 +143,7 @@ module.exports = function (internals, isModule) {
142143
}
143144

144145
if (!isModule && (internals.argv.help || internals.argv._.length === 0)) {
145-
optimist.showHelp();
146+
argParser.showHelp();
146147
process.exit(1);
147148
}
148149

0 commit comments

Comments
 (0)