-
Notifications
You must be signed in to change notification settings - Fork 111
Misc README updates #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
cd589ab
Add license and contributing sections to README.
susodapop 0c86ff6
Add environment setup docs to CONTRIBUTING
susodapop 1ddd597
Clarify example of connection details in example
susodapop 1fd4276
Add badges from pypi
dde1e3f
Explicitly call out Python 3.7 or above is needed
22bbd22
Clarify unit test invocation command
83c4753
Fix bad link
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
# Contributing | ||
|
||
To contribute to this repository, fork it and send pull requests. | ||
|
||
## Set up your environment | ||
|
||
This project uses [Poetry](https://python-poetry.org/) for dependency management, tests, and linting. | ||
|
||
1. Clone this respository | ||
2. Run `poetry install` | ||
|
||
### Unit Tests | ||
|
||
We use [Pytest](https://docs.pytest.org/en/7.1.x/) as our test runner. Invoke it with `poetry run pytest`, all other arguments are passed directly to `pytest`. | ||
|
||
#### All tests | ||
```bash | ||
poetry run pytest tests | ||
``` | ||
|
||
#### Only a specific test file | ||
|
||
```bash | ||
poetry run pytest tests/tests.py | ||
``` | ||
|
||
#### Only a specific method | ||
|
||
```bash | ||
poetry run pytest tests/tests.py::ClientTestSuite::test_closing_connection_closes_commands | ||
``` | ||
|
||
### Code formatting | ||
|
||
This project uses [Black](https://pypi.org/project/black/). | ||
|
||
``` | ||
poetry run black src | ||
``` | ||
## Pull Request Process | ||
|
||
1. Update the [CHANGELOG.md](README.md) or similar documentation with details of changes you wish to make, if applicable. | ||
2. Add any appropriate tests. | ||
3. Make your code or other changes. | ||
4. Review guidelines such as | ||
[How to write the perfect pull request][github-perfect-pr], thanks! | ||
|
||
[github-perfect-pr]: https://blog.github.com/2015-01-21-how-to-write-the-perfect-pull-request/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.