-
Notifications
You must be signed in to change notification settings - Fork 111
Misc README updates #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I couldn't add supported python versions. Poetry doesn't provide the correct trove classifiers based on our current Python specification. If this is important we can add it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I added two comments but they are not blocking comments. Please feel free to merge the PR. and look at those later.
CONTRIBUTING.md
Outdated
#### Specific tests | ||
|
||
```bash | ||
poetry run pytest tests/path/to/test.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how can I run a specific test method from a test file? does poetry support that?
(non blocking comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I added a more specific example in 22bbd22
* Add license and contributing sections to README. * Add environment setup docs to CONTRIBUTING * Clarify example of connection details in example * Add badges from pypi * Explicitly call out Python 3.7 or above is needed
* Add license and contributing sections to README. * Add environment setup docs to CONTRIBUTING * Clarify example of connection details in example * Add badges from pypi * Explicitly call out Python 3.7 or above is needed Signed-off-by: Sai Shree Pradhan <[email protected]>
Description