Rename get_column_names to column_names and make property
#254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there weren't any objections last time, and |
MarcoGorelli
added a commit
to MarcoGorelli/dataframe-api
that referenced
this pull request
Sep 27, 2023
…pis#254) * get_column_names -> column_names property * get_column_names -> column_names
MarcoGorelli
added a commit
that referenced
this pull request
Sep 28, 2023
* remove unused typevars, make dtype type alias * Rename `get_column_names` to `column_names` and make property (#254) * get_column_names -> column_names property * get_column_names -> column_names * add namespace protocol * fixup * add examples * add plotting example * fixup; * redirect examples * type check; * exclude examples from conf.py * post-merge fixup * add other example * fixup example; * noop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #245 and #246, trying to improve ergonomics whilst we're still "beta"
I think we've agreed that although the number of rows (and their ordering) isn't always known, we do always know the number of columns (if we didn't, then
get_column_nameswould already be broken), and that this shouldn't really involve any compute