Skip to content

Commit a62fe35

Browse files
committed
Rename get_column_names to column_names and make property (data-apis#254)
* get_column_names -> column_names property * get_column_names -> column_names
1 parent 3a52ce8 commit a62fe35

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

spec/API_specification/dataframe_api/dataframe_object.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ def insert_column(self, column: Column) -> DataFrame:
198198
.. code-block:: python
199199
200200
new_column = df.get_column_by_name('a') + 1
201-
new_columns_names = ['a_plus_1'] + df.get_column_names()
201+
new_columns_names = ['a_plus_1'] + df.column_names
202202
df = df.insert_column(new_column.rename('a_plus_1'))
203203
df = df.select(new_column_names)
204204
@@ -267,7 +267,8 @@ def rename_columns(self, mapping: Mapping[str, str]) -> DataFrame:
267267
"""
268268
...
269269

270-
def get_column_names(self) -> list[str]:
270+
@property
271+
def column_names(self) -> list[str]:
271272
"""
272273
Get column names.
273274

spec/purpose_and_scope.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ def my_dataframe_agnostic_function(df):
291291
mask = df.get_column_by_name('species') != 'setosa'
292292
df = df.filter(mask)
293293

294-
for column_name in df.get_column_names():
294+
for column_name in df.column_names
295295
if column_name == 'species':
296296
continue
297297
new_column = df.get_column_by_name(column_name)

0 commit comments

Comments
 (0)