Skip to content

add DataFrame.sorted_indices #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 27, 2023
Merged

add DataFrame.sorted_indices #128

merged 9 commits into from
Apr 27, 2023

Conversation

MarcoGorelli
Copy link
Contributor

closes #123

@MarcoGorelli MarcoGorelli marked this pull request as draft April 3, 2023 10:06
@MarcoGorelli MarcoGorelli marked this pull request as ready for review April 3, 2023 11:00
@rgommers rgommers changed the title add sort add DataFrame.sort Apr 13, 2023
@MarcoGorelli MarcoGorelli changed the title add DataFrame.sort add DataFrame.sorted_indices Apr 17, 2023
@MarcoGorelli
Copy link
Contributor Author

ok to get this in?

@rgommers rgommers mentioned this pull request Apr 27, 2023
Merged
rgommers
rgommers approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments were addressed, merging. Thanks all!

@rgommers rgommers merged commit c1b1ab1 into data-apis:main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments

@kkraus14 kkraus14 kkraus14 approved these changes

@jbrockmendel jbrockmendel jbrockmendel left review comments

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
API design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataFrame.sort(by=labels: Sequence[str])
5 participants
@MarcoGorelli @rgommers @jorisvandenbossche @kkraus14 @jbrockmendel