Skip to content

DataFrame.sort(by=labels: Sequence[str]) #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MarcoGorelli opened this issue Mar 30, 2023 · 3 comments · Fixed by #128
Closed

DataFrame.sort(by=labels: Sequence[str]) #123

MarcoGorelli opened this issue Mar 30, 2023 · 3 comments · Fixed by #128
Labels
API design

Comments

@MarcoGorelli
Copy link
Contributor

There's currently no sorting functionality. OK to add DataFrame.sort which takes a sequence of column names to sort by?
@kkraus14
Copy link
Collaborator

+1 from me

@MarcoGorelli MarcoGorelli mentioned this issue Apr 3, 2023
Merged
@jorisvandenbossche
Copy link
Member

I think people will want to be able to specify if it is an ascending or descending sort?

In addition to a general ascending/descending flag, some other possible options that I am aware off in other systems: ability to specify ascending/descending per sort key, specify behaviour of sorting NaNs/nulls (first vs last)

@MarcoGorelli MarcoGorelli mentioned this issue Apr 3, 2023
Closed
@MarcoGorelli
Copy link
Contributor Author

good point, thanks! have added both

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API design
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add DataFrame.sorted_indices MarcoGorelli/dataframe-api
4 participants
@rgommers @jorisvandenbossche @kkraus14 @MarcoGorelli