Skip to content

Move linear algebra APIs to an extension #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2021
Merged

Move linear algebra APIs to an extension #182

merged 3 commits into from
May 20, 2021

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented May 16, 2021

This PR

  • builds on gh-165 whereby only a small subset of linear algebra APIs are present in the top-level namespace and the rest are specified in a dedicated linalg sub-namespace as an extension to the array API standard.

Notes

  • How extensions should be authored and consumed remains to be decided. This PR should lay the groundwork for further specification.

@kgryte kgryte requested a review from rgommers May 16, 2021 03:16
@asmeurer
Copy link
Member

Did we decide to mirror the functions in the top-level namespace?

@rgommers
Copy link
Member

Did we decide to mirror the functions in the top-level namespace?

I believe that was indeed the preferred option. Discussion at #149 (review) followed by a discussion in the May 6th call where people seemed happy with @kgryte's proposal as implemented in this PR.

For others, it may help to capture how the PR in its current state is rendered. The API specification for the main namespace has these functions:

image

Extensions is a separate section:

image

And that section has all linear algebra functions in it (including the 5 in the main namespace, which are aliased).

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kgryte

@rgommers rgommers added the Narrative Content Narrative documentation content. label May 16, 2021
@rgommers
Copy link
Member

Let me merge this, since people are busy implementing this in at least PyTorch. If there are more comments, let's deal with those in a follow-up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Narrative Content Narrative documentation content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants