-
Notifications
You must be signed in to change notification settings - Fork 53
Add linear algebra design principles #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @kgryte. Two other things come to mind:
- Namespaces. NumPy has the weird split between in linalg functions between its main namespace and
numpy.linalg
. Other libraries tend to follow that. There's no optimal solution; we should say something about it here though. - You may want to include a part of Add specification for computing the dot product (linalg: vecdot) #137. A principle may be "orthogonality", which is a reason for including only certain "dot" functions.
@rgommers I've added an orthogonality principle and a note regarding namespaces. |
0607525
to
138e963
Compare
…linalg-design-principles
I've removed the note, and will submit a follow-up PR regarding the mirroring of top-level linear algebra APIs in the |
This PR