-
Notifications
You must be signed in to change notification settings - Fork 45
More torch fixes #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More torch fixes #184
Conversation
4ad8996
to
7a1664a
Compare
Better reflect the specs naming convention and avoid confusion with complex
Here's another error:
|
There's also this error. I can't tell if it's caused by this or something else:
|
I think that's it. Every other test failure seems to be either an issue with torch or an unrelated test suite problem which I've reported elsewhere. |
Not that it's that important, but can we address #181 (comment) here? |
Fixed and fixed—thanks for catching these. I folded in #182 as it addresses the former issue. Whilst its nice to keep PRs atomic I think we're not keeping track of multiple PRs at once, so mono PRs with at least a general cohesion is probably better.
Already addressed! |
complex
builtin for complex dtypes in get_scalar_type
(I'll merge this soon if no review) |
_UndefinedStub
indtype_helpers.py
hh.reject_overflow()
context manager that deals with non-OverflowError
overflow errors (i.e. torch'sRuntimeError: ...overflow...
)