Skip to content

Tests for comparison functions should not use complex dtypes #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
asmeurer opened this issue Apr 18, 2023 · 0 comments · Fixed by #184
Closed

Tests for comparison functions should not use complex dtypes #180

asmeurer opened this issue Apr 18, 2023 · 0 comments · Fixed by #184

Comments

@asmeurer
Copy link
Member

These tests fail with pytorch, but they should not be using complex inputs:

FAILED array_api_tests/test_searching_functions.py::test_argmax - RuntimeError: "argmax_cpu" not implemented for 'ComplexFloat'
FAILED array_api_tests/test_searching_functions.py::test_argmin - RuntimeError: "argmin_cpu" not implemented for 'ComplexFloat'
FAILED array_api_tests/test_sorting_functions.py::test_argsort - RuntimeError: "sorting_kernel_method_name" not implemented for 'ComplexFloat'
FAILED array_api_tests/test_sorting_functions.py::test_sort - RuntimeError: "sorting_kernel_method_name" not implemented for 'ComplexFloat'
FAILED array_api_tests/test_statistical_functions.py::test_max - RuntimeError: "max_values_cpu" not implemented for 'ComplexFloat'
FAILED array_api_tests/test_statistical_functions.py::test_min - RuntimeError: "min_values_cpu" not implemented for 'ComplexFloat'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More torch fixes honno/array-api-tests
1 participant
@asmeurer