Use analyzer line number library #2034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pq
approved these changes
Oct 7, 2019
Cliabhach
added a commit
to Cliabhach/dartdoc
that referenced
this pull request
Apr 19, 2022
Fixes compat with timezone 0.8.0 We try to place error messages for synthetic elements at either its setter or at its getter. Before now, that setter/getter had to be both public and synthetic; now, we'll just print a warning if that check fails. Note that we still error out if we can't find any setter or getter. Related to dart-lang#2034
Cliabhach
added a commit
to Cliabhach/dartdoc
that referenced
this pull request
May 17, 2022
Fixes compat with timezone 0.8.0 We try to place error messages for synthetic elements at either its setter or at its getter. Before now, that setter/getter had to be both public and synthetic; now, we'll just print a warning if that check fails. Note that we still error out if we can't find any setter or getter. Related to dart-lang#2034
Cliabhach
added a commit
to Cliabhach/dartdoc
that referenced
this pull request
Jun 11, 2022
Fixes compat with timezone 0.8.0 We try to place error messages for synthetic elements at either its setter or at its getter. Before now, that setter/getter had to be both public and synthetic; now, we'll just print a warning if that check fails. Note that we still error out if we can't find any setter or getter. Related to dart-lang#2034
Cliabhach
added a commit
to Cliabhach/dartdoc
that referenced
this pull request
Jan 10, 2023
Fixes compat with timezone 0.8.0 We try to place error messages for synthetic elements at either its setter or at its getter. Before now, that setter/getter had to be both public and synthetic; now, we'll just print a warning if that check fails. Note that we still error out if we can't find any setter or getter. Related to dart-lang#2034
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1938, replacing #1939.
This removes the line number cache from dartdoc and also fixes a number of minor problems in addition to #1938:
toString()Dartdoc overall is very slightly faster as well (~1%), we were spending a measurable amount time counting lines that the analyzer had already figured out.