Fix line number cache #1939
Closed
Fix line number cache #1939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pq
approved these changes
Feb 20, 2019
test/line_number_cache_test.dart
Outdated
| @@ -0,0 +1,65 @@ | |||
| // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file | |||
| import 'package:dartdoc/src/line_number_cache.dart'; | ||
| import 'package:path/path.dart' as pathLib; | ||
| import 'package:test/test.dart'; | ||
| import 'package:dartdoc/src/tuple.dart'; |
test/line_number_cache_test.dart
Outdated
|
|
||
| test('single line without newline', () { | ||
| File singleLineWithoutNewline = | ||
| File(pathLib.join(_tempDir.path, 'single_line')) |
There was a problem hiding this comment.
It hardly matters but I'm a little surprised to see news elided here (and not elsewhere).
There was a problem hiding this comment.
new is now consistently absent.
jcollins-g
commented
Sep 30, 2019
test/line_number_cache_test.dart
Outdated
| @@ -0,0 +1,65 @@ | |||
| // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file | |||
| import 'package:dartdoc/src/line_number_cache.dart'; | ||
| import 'package:path/path.dart' as pathLib; | ||
| import 'package:test/test.dart'; | ||
| import 'package:dartdoc/src/tuple.dart'; |
test/line_number_cache_test.dart
Outdated
|
|
||
| test('single line without newline', () { | ||
| File singleLineWithoutNewline = | ||
| File(pathLib.join(_tempDir.path, 'single_line')) |
There was a problem hiding this comment.
new is now consistently absent.
jcollins-g
requested review from
pq
and removed request for
pq and
devoncarew
|
This results in a display error as originally written for locations that can't be found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1938. The line number cache had some fencepost problems and this corrects them, adding tests. Also eliminates caching of file contents that won't be used more than once, anyway.
Note: dartfmt has some ideas about formatting that seem to have changed in the last version. See the first commit for real changes.