Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

fix(web components): Fix tests in IE10 #1372

Closed
wants to merge 1 commit into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Aug 20, 2014

@jbdeboer could you please review this PR, I'd like to get this in ASAP as it would allow enabling the tests on IE10.

The tests pass on IE10 with this update (there is actually a failure in that branch but no more related to wc)

Thanks to @vsavkin for helping me find the root cause of the issue.

@mhevery mhevery added cla: yes and removed cla: no labels Aug 20, 2014
@jbdeboer
Copy link
Contributor

I am out today, but can look tomorrow.

On Wed, Aug 20, 2014 at 2:06 AM, Victor Berchet [email protected]
wrote:

@jbdeboer https://github.com/jbdeboer could you please review this PR,
I'd like to get this in ASAP as it would allow enabling the tests on IE10.

The tests pass on IE10
https://travis-ci.org/vicb/angular.dart/builds/33049150 with this update

Thanks to @vsavkin https://github.com/vsavkin for helping me find the

root cause of the issue.

You can merge this Pull Request by running

git pull https://github.com/vicb/angular.dart 0820-ie10proto

Or view, comment on, or merge it at:

#1372
Commit Summary

  • fix(web components): Fix tests in IE10

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#1372.

@vicb
Copy link
Contributor Author

vicb commented Aug 20, 2014

great, thanks.

@jbdeboer
Copy link
Contributor

I will merge this change on Monday.

vicb added a commit that referenced this pull request Aug 25, 2014
@vicb vicb closed this in 43b6f4f Aug 25, 2014
@vicb vicb mentioned this pull request Aug 25, 2014
16 tasks
@vicb vicb deleted the 0820-ie10proto branch August 31, 2014 07:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants