-
Notifications
You must be signed in to change notification settings - Fork 248
Running the test suite on more platforms #1288
Conversation
This PR is ready to merge. We'll add IE10 and Safari6 once the corresponding defects are fixed. |
@vicb, the g3 conflicts should be resolved, could you rebase and re-run the Travis tests? |
It was pending #1372, I will rebase tomorrow (& enable IE10) |
00c1845
to
5d91031
Compare
@jbdeboer the PR has been rebased and the test suite pass. It is ready to be reviewed/merged. Note: Safari 6 is still not part of this PR, @matsko works on #1320. IE10, IE11 and Safari 7 are tested |
Assigned to @vsavkin to review and flip the "mergable" bit. |
path should not be null, it would extrapolate to "null"
The error message varies across browsers: Dartium -> "Unexpected character" Dart2JS: - Chrome -> "Unexpected token" - Firefox -> "unexpected character" - IE -> "Invalid character"
…d differently on IE
- "#000000" for Chrome and Firefox - "" for Safari7 and IE11
e3181b2
to
afbb13c
Compare
@jbdeboer it was not possible to merge this PR before g3 was updated (which should have been done by @vsavkin at the end of last week). There are still issues with the URL resolver, @chirayuk could you please take a look. Thanks. |
@vicb, I know you can not merge the whole PR, but there are a number of simple commits that can be merged while we wait for other blockers to be resolved. That will reduce your rebase pain and allows everybody to make progress. e.g. The "cleanup" commits are simple and could go in right away |
My reasoning is that the only commit that blocks us (resolving relative URLs) has a handful of other bugs - let's see if we decide to revert this before. |
That's one solution but I really don't understand why the URL resolver is left into master with at least 3 bugs ?? |
Closed via #1464 The merged PR has IE and Safari disabled due to issues with Sauce Labs.
|
We want to enable the testing on more browsers / platforms thanks to SauceLabs.
I would need some help to fix the tests for Safari (I don't have a Mac available). To start with, checking the issues with the animation would help (other issues might also be observe on IE and I'll try to fix them).
@codelogic @mhevery @jbdeboer could any of you look at the issues on Safari ?
Fixed tests:
ShadowDomComponentFactory
should return consistent response across platforms (line endings) - fixed by removing\n
null
<select>
reports multiple selected optionsTODO: