Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Running the test suite on more platforms #1288

Closed
wants to merge 21 commits into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jul 31, 2014

We want to enable the testing on more browsers / platforms thanks to SauceLabs.

I would need some help to fix the tests for Safari (I don't have a Mac available). To start with, checking the issues with the animation would help (other issues might also be observe on IE and I'll try to fix them).

@codelogic @mhevery @jbdeboer could any of you look at the issues on Safari ?

Fixed tests:

  • Fix unit tests on IE 11,
    • ShadowDomComponentFactory should return consistent response across platforms (line endings) - fixed by removing \n
    • Cookies should work - fixed by set path default to "" instead of null
    • Web platform does not work - skip tests on IE, issue WebPlatform bug ? #1300 assigned to @vsavkin
    • ng-mousewheel should evaluate the expression on mousewheel FAILED - changed the triggered event name from "wheel" to "mousewheel"
    • form onSubmit should suppress the submission event if no action is provided within the form FAILED - bug in DartJs, test disabled, see Tracking issue for custom events #1309
    • <select> reports multiple selected options
    • ng-model should write to input only if the value is different FAILED - fixed, the issue was how we detect write (IE and others do not handle el.selectionStart & el.selectionEnd in the same way)
    • ng-model type="color", fixed, IE & Safari do not have the same default value as Chrome & FF
  • Fix unit tests on Safari,
    • CssAnimation fails to add / remove class - assigned to @matsko, Safari 6 fails, 7 is ok. Do no test on Safari 6 before Animation does not work on Safari 6 #1320 gets resolved.
    • input type="number" on Sf6, skip the test
    • Cookies - same issue as IE

TODO:

@vicb vicb added cla: yes and removed cla: no labels Jul 31, 2014
@vicb vicb self-assigned this Jul 31, 2014
@vicb vicb mentioned this pull request Aug 4, 2014
@vicb
Copy link
Contributor Author

vicb commented Aug 6, 2014

This PR is ready to merge.

We'll add IE10 and Safari6 once the corresponding defects are fixed.

@vicb vicb changed the title [WIP] Running the test suite on more platforms Running the test suite on more platforms Aug 6, 2014
@vicb vicb added this to the vicb-0.14 milestone Aug 13, 2014
@jbdeboer
Copy link
Contributor

@vicb, the g3 conflicts should be resolved, could you rebase and re-run the Travis tests?

@vicb
Copy link
Contributor Author

vicb commented Aug 25, 2014

It was pending #1372, I will rebase tomorrow (& enable IE10)

@vicb vicb force-pushed the 0731-platforms branch 2 times, most recently from 00c1845 to 5d91031 Compare August 26, 2014 14:23
@vicb vicb removed this from the vicb-0.14 milestone Aug 26, 2014
@vicb
Copy link
Contributor Author

vicb commented Aug 26, 2014

@jbdeboer the PR has been rebased and the test suite pass. It is ready to be reviewed/merged.

Note: Safari 6 is still not part of this PR, @matsko works on #1320. IE10, IE11 and Safari 7 are tested

@jbdeboer jbdeboer assigned vsavkin and unassigned vicb Aug 26, 2014
@jbdeboer
Copy link
Contributor

Assigned to @vsavkin to review and flip the "mergable" bit.

@vicb
Copy link
Contributor Author

vicb commented Sep 15, 2014

@jbdeboer it was not possible to merge this PR before g3 was updated (which should have been done by @vsavkin at the end of last week).

There are still issues with the URL resolver, @chirayuk could you please take a look. Thanks.

@jbdeboer
Copy link
Contributor

@vicb, I know you can not merge the whole PR, but there are a number of simple commits that can be merged while we wait for other blockers to be resolved.

That will reduce your rebase pain and allows everybody to make progress.

e.g. The "cleanup" commits are simple and could go in right away
e.g. We are blocked on IE, but that does not prevent Safari support from being committed.

@vicb
Copy link
Contributor Author

vicb commented Sep 15, 2014

My reasoning is that the only commit that blocks us (resolving relative URLs) has a handful of other bugs - let's see if we decide to revert this before.

@vsavkin
Copy link
Contributor

vsavkin commented Sep 16, 2014

@vicb I'm going to remove IE from the .travis and merge the PR. Once @chirayuk fix the issues with the URL resolver, he can enable IE.

@vicb
Copy link
Contributor Author

vicb commented Sep 16, 2014

That's one solution but I really don't understand why the URL resolver is left into master with at least 3 bugs ??

@vsavkin
Copy link
Contributor

vsavkin commented Sep 17, 2014

Closed via #1464

The merged PR has IE and Safari disabled due to issues with Sauce Labs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

5 participants