Clean up export. #1313
Clean up export. #1313
Conversation
|
Thanks for your contribution! In order for us to be able to accept it, we ask you to sign our CLA (contributor's license agreement). CLA is important for us to be able to avoid legal troubles down the road. For individuals (a simple click-through form): http://code.google.com/legal/individual-cla-v1.0.html |
|
LGTM, please amend the commit to follow the guidelines for comments (https://github.com/angular/angular.dart/blob/master/CHANGELOG.md) |
|
I've signed up now (I'm working for Google, too). I'll amend the commit On Tue, Aug 5, 2014 at 11:02 AM, Victor Berchet [email protected]
|
|
Okay. I've amended the commit message. Not sure whether it is a fix or a refactor though ^^ |
ShadowRootAware is defined in annotation.dart and not in annotation_src.dart.
|
Anything else I need to do to update this request? Thanks, |
|
@BlackHC – all I need from you is to sign the CLA with the gmail address you used for the commit (visit http://code.google.com/legal/individual-cla-v1.0.html.) We use an automated test to determine if someone has signed the CLA based on it and this also allows re-verification for future commits. I'll merge it in shortly after. |
|
Done. It's weird though because I've already signed up in our internal list as well. Thanks, |
|
Merged. Thanks for signing the CLA. I'll mail you @google.com about the CLA list. |
ShadowRootAware is defined in annotation.dart and not in annotation_src.dart. Closes #1313
Completely remove the deprecated Controller directive. Major update to the demos to use setRootContext (where applicable) and to move to Components for the beefier demos (bouncing balls and form). A temporary work around was required in demos (animation and todo) so that rootContext have Map interface. The work arounds will disappear after the context is set to the component. Library changes were pulled out of the first commit in #1269. Closes #1401
ShadowRootAware is defined in annotation.dart and not in annotation_src.dart.