Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

ShadowRootAware should not be defined in lib/core/annotation.dart #1531

Closed
BlackHC opened this issue Oct 9, 2014 · 2 comments
Closed

ShadowRootAware should not be defined in lib/core/annotation.dart #1531

BlackHC opened this issue Oct 9, 2014 · 2 comments
Milestone

Comments

@BlackHC
Copy link
Contributor

BlackHC commented Oct 9, 2014

ShadowRootAware is a helper interface and not an annotation. Because it is defined in annotation.dart, it pulls dart:html import into annotation.dart as well, which makes it impossible to write non-drt tests for dart components, even though simple components might not require it otherwise.

Moreover, a recent PR #1401 undid PR #1313 that fixed a spurious export (ShadowRootAware from annotation_src.dart) that does not exist anymore.

@rkirov
Copy link
Contributor

rkirov commented Oct 9, 2014

Created a PR to move all aware interfaces into their own library, because I agree that they are not annotations. This is roll-forward the clean-up #1313 that got accidentally rolled back.

However, you will still have the problem that as soon as one of your components needs an aware interface you will need a dart:html enabled VM (even if it is just ScopeAware). A full clean separation of angular internals into html-dependent and html-independent has benefits but might be too much work (definitely not a goal for v1.0.)

@rkirov rkirov added this to the v1.0 milestone Oct 9, 2014
@rkirov rkirov self-assigned this Oct 9, 2014
@rkirov rkirov modified the milestones: 1.1, v1.0 Oct 10, 2014
@BlackHC
Copy link
Contributor Author

BlackHC commented Nov 17, 2014

Thanks! No worries! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants