You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Feb 22, 2018. It is now read-only.
ShadowRootAware is a helper interface and not an annotation. Because it is defined in annotation.dart, it pulls dart:html import into annotation.dart as well, which makes it impossible to write non-drt tests for dart components, even though simple components might not require it otherwise.
Moreover, a recent PR #1401 undid PR #1313 that fixed a spurious export (ShadowRootAware from annotation_src.dart) that does not exist anymore.
The text was updated successfully, but these errors were encountered:
Created a PR to move all aware interfaces into their own library, because I agree that they are not annotations. This is roll-forward the clean-up #1313 that got accidentally rolled back.
However, you will still have the problem that as soon as one of your components needs an aware interface you will need a dart:html enabled VM (even if it is just ScopeAware). A full clean separation of angular internals into html-dependent and html-independent has benefits but might be too much work (definitely not a goal for v1.0.)
ShadowRootAware is a helper interface and not an annotation. Because it is defined in annotation.dart, it pulls dart:html import into annotation.dart as well, which makes it impossible to write non-drt tests for dart components, even though simple components might not require it otherwise.
Moreover, a recent PR #1401 undid PR #1313 that fixed a spurious export (ShadowRootAware from annotation_src.dart) that does not exist anymore.
The text was updated successfully, but these errors were encountered: