This repository was archived by the owner on Feb 22, 2018. It is now read-only.
Precompute Scope.watch ASTs #1088
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comments please; I plan on starting to merge this PR tomorrow. @IgorMinar Made the point that after the context parameter is removed, these could be simply cached after the first View is created.. |
|
One general comment is that I've changed the ASTParser to be private a few weeks ago. |
…t:o) This is the only place where Scope.watch(context:o) is used and it is in the way of optimizations. For dart-archive#1086
Scope.watch should no longer switch context. Instead of saying
scope.watch(expression, (v, _) { }, context: o);
Create a new isolate child scope
scope.createChild(o).watch(expression, (v, _) { });
-> Make it injectable -> Remove try/catch statements are extra state -> Rename AstParser -> ASTParser -> Rename ExpressionVisitor -> _ExpressionVisitor For dart-archive#1086
dsalsbury
pushed a commit
to dsalsbury/angular.dart
that referenced
this pull request
Jul 16, 2014
dsalsbury
pushed a commit
to dsalsbury/angular.dart
that referenced
this pull request
Jul 16, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.