Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Upgrade all scope.watch calls to scope.watchAST #1110

Open
jbdeboer opened this issue Jun 5, 2014 · 5 comments
Open

Upgrade all scope.watch calls to scope.watchAST #1110

jbdeboer opened this issue Jun 5, 2014 · 5 comments

Comments

@jbdeboer
Copy link
Contributor

jbdeboer commented Jun 5, 2014

Or eliminate them entirely.

Once #1088 has landed, we should fix up all the calls to scope.watch (e.g in directives). There are probably cases where we do not need the Scope.watch calls at all.

@jbdeboer
Copy link
Contributor Author

jbdeboer commented Jun 5, 2014

@markovuksanovic Could you take this issue? I will be landed #1088 this morning.

@mvuksano
Copy link
Contributor

mvuksano commented Jun 5, 2014

@jbdeboer sure.

@mvuksano
Copy link
Contributor

mvuksano commented Jun 9, 2014

@jbdeboer I guess this also includes RootScope.watch, right?

@mhevery
Copy link
Contributor

mhevery commented Jun 26, 2014

AST should not be visible to the public. There should be a better way to do this.

@mvuksano
Copy link
Contributor

Well, I guess in theory we could cache all the expressions watched, i.e have some service within scope which caches expressions and then when an expression is watched we check if we have a AST for the expression and if not do the parsing.

Then the next step could be to run a transformer and populate the AST cache during compile time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging a pull request may close this issue.

3 participants