This repository was archived by the owner on Feb 22, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 248
Upgrade all scope.watch calls to scope.watchAST #1110
Labels
Comments
@markovuksanovic Could you take this issue? I will be landed #1088 this morning. |
@jbdeboer sure. |
@jbdeboer I guess this also includes RootScope.watch, right? |
AST should not be visible to the public. There should be a better way to do this. |
Well, I guess in theory we could cache all the expressions watched, i.e have some service within scope which caches expressions and then when an expression is watched we check if we have a AST for the expression and if not do the parsing. Then the next step could be to run a transformer and populate the AST cache during compile time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Or eliminate them entirely.
Once #1088 has landed, we should fix up all the calls to scope.watch (e.g in directives). There are probably cases where we do not need the Scope.watch calls at all.
The text was updated successfully, but these errors were encountered: