This repository was archived by the owner on Feb 22, 2018. It is now read-only.
fix(Http): Fix NoSuchMethodError in Http #1075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * - cache: Boolean or [Cache]. If true, the default cache will be used. | ||
| * - cache: Boolean or [Cache]. If true or not specified at all, the default cache will be used. | ||
| * If false, no cache will be used. If object of type [Cache] is provided, that object will | ||
| * be used as cache. | ||
| * - timeout: deprecated |
There was a problem hiding this comment.
What about a bullet list here
- if true/null, the [defaults.cache] will be used,
- if false ...
- if object of type [Cache] ...
[defaults.cache] better describes what is used (and it could actually not be a cache, ie null)
|
Looks good to merge |
update documentation about cache usage. Closes dart-archive#1066
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix NoSuchMethodError in Http when cache set to true and update documentation about cache usage.
Closes #1066