Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Http documentation doesn't match code functionality #1066

Closed
tpng opened this issue May 26, 2014 · 0 comments · Fixed by #1075
Closed

Http documentation doesn't match code functionality #1066

tpng opened this issue May 26, 2014 · 0 comments · Fixed by #1075

Comments

@tpng
Copy link

tpng commented May 26, 2014

In the document:
https://github.com/angular/angular.dart/blob/master/lib/core_dom/http.dart#L418
It states that passing true will use the default cache.

But in the code:
https://github.com/angular/angular.dart/blob/master/lib/core_dom/http.dart#L469
Behaviors are

  1. passing false will disable the cache,
  2. passing null or not passing cache parameter will use the default cache,
  3. passing true result in NoSuchMethodError (since cache method is called on the bool value)
@tpng tpng changed the title Http document doesn't match code functionality Http documentation doesn't match code functionality May 26, 2014
@vicb vicb assigned mvuksano and unassigned vicb May 26, 2014
mvuksano added a commit to mvuksano/angular.dart that referenced this issue May 28, 2014
mvuksano added a commit to mvuksano/angular.dart that referenced this issue May 28, 2014
mvuksano added a commit to mvuksano/angular.dart that referenced this issue May 28, 2014
mvuksano added a commit to mvuksano/angular.dart that referenced this issue May 28, 2014
mvuksano added a commit to mvuksano/angular.dart that referenced this issue May 28, 2014
mvuksano added a commit to mvuksano/angular.dart that referenced this issue May 30, 2014
mvuksano added a commit to mvuksano/angular.dart that referenced this issue Jun 3, 2014
mvuksano added a commit to mvuksano/angular.dart that referenced this issue Jun 4, 2014
mvuksano added a commit to mvuksano/angular.dart that referenced this issue Jun 4, 2014
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Jul 16, 2014
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Jul 16, 2014
mvuksano added a commit that referenced this issue Aug 5, 2014
mvuksano added a commit that referenced this issue Aug 8, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants