Enable GitHub actions #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miraculixx
force-pushed
the
enable-github-actions
branch
3 times, most recently
from
dae5ade to
b185a7d
Compare
miraculixx
force-pushed
the
enable-github-actions
branch
from
b185a7d to
018dee6
Compare
This was referenced May 23, 2022
AbdealiLoKo
reviewed
May 26, 2022
| @@ -130,3 +130,8 @@ dmypy.json | |||
|
|
|||
| # Project specific | |||
| configurable_http_proxy/version.txt | |||
| /.idea/configurable-http-proxy.iml | |||
There was a problem hiding this comment.
We should just make a separate section for # Editors and ignore the entire /.idea folder
AbdealiLoKo
reviewed
May 26, 2022
| python -m pip install --upgrade pip | ||
| pip install flake8 pytest | ||
| pip install -r requirements.txt | ||
| pip install -e . |
There was a problem hiding this comment.
-r requirements.txt is not required as the -e . will already install those dependencies
|
Wanted to make some changes based on the comments I added, so I have moved this to #12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2
notes