Skip to content

Support a db backend for high availability scenarios #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
miraculixx opened this issue Apr 29, 2022 · 2 comments · Fixed by #11
Closed

Support a db backend for high availability scenarios #9

miraculixx opened this issue Apr 29, 2022 · 2 comments · Fixed by #11
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@miraculixx
Copy link
Contributor

To enable running chp multiple times in a HA scenario it needs to support a database backend (instead of in-memory, as currently).

Requirements:

  • implement store.DatabaseStore using sqlalchemy for max flexibility
  • add tests
  • make this an optional requirement, e.g. pip install configurable-http-proxy[sqla]
@AbdealiLoKo
Copy link
Collaborator

Hi @miraculixx That sounds like a cool idea.
I would be very open to merge a PR with this addition.

So I understand it better - does the current javascript based configurable-http-proxy have a database store already ?
Or how do you handle this with it with the current CHP ?
Trying to understand if this is a feature parity issue that should be documented in the README or is this a new request for the proxy which doesn't exist so far

@AbdealiLoKo AbdealiLoKo added enhancement New feature or request help wanted Extra attention is needed labels May 2, 2022
@miraculixx
Copy link
Contributor Author

miraculixx commented May 23, 2022

Hi @AbdealiJK, thanks for your feedback!

does the current javascript based configurable-http-proxy have a database store already

Unfortunately no, but it does have support for pluggable storage, as you know I guess, and there is this Redis implementation. However, I need one that works with an SQL DBMS. Since my stack is almost entirely Python, your project would be straight forward.

I would be very open to merge a PR with this addition.

Glad to hear! Please see #11. I also added #10 to automatically run unittests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants