Skip to content

fix: upgrade babel from 6 to 7 #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 26, 2020

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Jan 3, 2020

Description

Doing this update was not trivial task, a lot of dependencies relied on older version of packages and i upgraded only what i had to.

Changes

  • migrate from babel 6 to babel 7
  • upgrade ava 0.x to 2.4 - relies heavily on babel
  • upgrade all require/exports. to import/export
  • drop babel-polyfill and replace it with direct reference to corejs@3
    corejs@2 is no longer maintained

Motivation and Context

corejs@2 is no longer maintained, babel@6 is outdated

Usage examples

No changes

How Has This Been Tested?

Unit tests

Types of changes

  • Dependencies
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I updated tests to run with new versions of ava

@armano2 armano2 changed the title feat: upgrade babel from 6 to 7 fix: upgrade babel from 6 to 7 Jan 3, 2020
@armano2
Copy link
Contributor Author

armano2 commented Jan 3, 2020

if its ok, in follow up PR i'm planning to drop proxyrequire (this package is no longer needed).
and upgrading all tests from ava to jest

@byCedric
Copy link
Member

byCedric commented Jan 3, 2020

This is some solid work, thanks ❤️ I'll review it asap, it's kind of big 😄 Can definitely help us move the TypeScript refactor forward again! @marionebl @escapedcat What do you think?

@byCedric byCedric requested a review from marionebl January 3, 2020 20:59
@byCedric
Copy link
Member

byCedric commented Jan 4, 2020

Looks good to me! ❤️ What do you think @marionebl @escapedcat?

@escapedcat
Copy link
Member

Great job! Thanks a bunch!

Conflicts:
	@commitlint/load/package.json
	@commitlint/prompt/package.json
	@commitlint/travis-cli/package.json
	yarn.lock
@byCedric
Copy link
Member

@armano2 Thanks for all the effort you put into this PR, I'm going to merge and continue from there with the TypeScript refactor ❤️ (cc @marionebl, @escapedcat)

@byCedric byCedric merged commit 2549f79 into conventional-changelog:master Jan 26, 2020
@armano2 armano2 deleted the upgrade-babel branch January 26, 2020 13:17
@stieben
Copy link

stieben commented Apr 10, 2020

It would be awesome to see this change published to npm, as the current v8.3.5 causes a warning regarding corejs@2 being no longer maintained.

(As of now, master is 99 commits ahead of v8.3.5.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants