-
Notifications
You must be signed in to change notification settings - Fork 934
fix: upgrade babel from 6 to 7 #886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upgrade babel from 6 to 7 #886
Conversation
corejs@2 is deprecated
if its ok, in follow up PR i'm planning to drop |
This is some solid work, thanks ❤️ I'll review it asap, it's kind of big 😄 Can definitely help us move the TypeScript refactor forward again! @marionebl @escapedcat What do you think? |
This reverts commit eba4002.
Looks good to me! ❤️ What do you think @marionebl @escapedcat? |
Great job! Thanks a bunch! |
Conflicts: @commitlint/load/package.json @commitlint/prompt/package.json @commitlint/travis-cli/package.json yarn.lock
@armano2 Thanks for all the effort you put into this PR, I'm going to merge and continue from there with the TypeScript refactor ❤️ (cc @marionebl, @escapedcat) |
It would be awesome to see this change published to npm, as the current (As of now, |
Description
Doing this update was not trivial task, a lot of dependencies relied on older version of packages and i upgraded only what i had to.
Changes
require/exports.
toimport/export
babel-polyfill
and replace it with direct reference tocorejs@3
corejs@2
is no longer maintainedMotivation and Context
corejs@2 is no longer maintained, babel@6 is outdated
Usage examples
No changes
How Has This Been Tested?
Unit tests
Types of changes
Checklist:
My change requires a change to the documentation.I have updated the documentation accordingly.