Skip to content

chore(cli): replaced babel-polyfill with @babel/polyfill #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore(cli): replaced babel-polyfill with @babel/polyfill #868

wants to merge 1 commit into from

Conversation

L2jLiga
Copy link

@L2jLiga L2jLiga commented Nov 26, 2019

Description

babel-polyfill was renamed to @babel/polyfill

Motivation and Context

As far as package was renamed we will not get any updates for it.

How Has This Been Tested?

via commit hook

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@escapedcat
Copy link
Member

@byCedric not sure if this is still needed when everything is eventaully moved to TS.

@rfgamaral
Copy link

@byCedric not sure if this is still needed when everything is eventaully moved to TS.

Can't this PR be merged anyway?

I mean, in the mean time (until everything is moved to TS) we get this:

warning @commitlint/cli > babel-polyfill > [email protected]: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.
warning @commitlint/cli > babel-polyfill > babel-runtime > [email protected]: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.

It would be nice to get rid of that warning... :)

@armano2
Copy link
Contributor

armano2 commented Jan 31, 2020

@rfgamaral this is no longer needed as babel-polyfill got removed in #886 as part of babel@6 to babel@7 migration

https://github.com/conventional-changelog/commitlint/blob/master/%40commitlint/cli/package.json

cc @byCedric

@rfgamaral
Copy link

@armano2 Why am I still getting the warning then? 😕

@armano2
Copy link
Contributor

armano2 commented Jan 31, 2020

seems that there was no release yet with this change

last release was 15 days ago, this change got merged 5 days ago

@rfgamaral
Copy link

Thanks for the clarification :)

@L2jLiga
Copy link
Author

L2jLiga commented Feb 1, 2020

Okey-dokey, I close this

@L2jLiga L2jLiga closed this Feb 1, 2020
@L2jLiga L2jLiga deleted the chore/babel-polyfill branch February 1, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants