Skip to content

feat(config-nx-scopes): update nx dependency version to ^15.0.0 #3414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

trystan2k
Copy link
Contributor

Description

Update NX dev and peer dependencies version to version ^15.0.0

Motivation and Context

Fixes #3413.

A new NX version was release some days ago and when you update NX in our repository, npm install fails with Conflicting peer dependency: [email protected] as @commitlint/config-nx-scopes has a peerDependency set to ^14.0.0 for NX.

The way @commitlint/config-nx-scopes search for the scopes (NX projects) is not affected, so this is only an update in package.json.

I also updated the fixture files to have the latest version format, but this does not affect this plugin.

I have changed the NX version in peerDependency to ^15.0.0 (instead of support both 14 and 15). Not sure if it is better to add it as ^14.0.0 || ^15.0.0, if so, please let me know, and I will change it

Usage examples

// commitlint.config.js
module.exports = {};
echo "your commit message here" | commitlint # fails/passes

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@escapedcat
Copy link
Member

The check atre not working. Usually the problem is that a contributor does not have a circle-ci account. Do you have one? If not would you mind creating one? Than the checks should run.

@trystan2k
Copy link
Contributor Author

The check atre not working. Usually the problem is that a contributor does not have a circle-ci account. Do you have one? If not would you mind creating one? Than the checks should run.

Yes, I didn't had a circle-ci account. I have just created it. Not sure how/if I can re-run the checks thought. Is it something I can do or need to be you ?

@escapedcat
Copy link
Member

escapedcat commented Oct 31, 2022

Are you able to open this and click "rerun"?:
https://app.circleci.com/pipelines/github/conventional-changelog/commitlint/7297
image
I don't have permissions in this case.

@trystan2k
Copy link
Contributor Author

I can go to this link, but it is also disabled for me...

I will delete this PR and open a new one, to see if it works.

@trystan2k trystan2k closed this Oct 31, 2022
@escapedcat
Copy link
Member

Ok, thanks! Sorry!
An empty commit might help as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

feat: add support nx@^15.0.0 in config-nx-scopes
2 participants