-
Notifications
You must be signed in to change notification settings - Fork 934
feat: add support nx@^15.0.0 in config-nx-scopes #3413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @escapedcat , I have just publish a PR to solve this. Instead of update version as proposed in this issue Let me know if I need to change it to the || option. |
I guess that would a breaking change then, right? Woudl be ok I guess. |
Yep, that would be a breaking change. But I guess that if someone jump from a major release of NX (from 14.x to 15.x), it should also mean a major update for other dependencies too. |
I see no reason to drop support for Nx 14 until config-nx-scopes actually requires some newer Nx feature. |
Fair enough |
Should I then change the peerDependency to |
@Phault is right, as long as there is no need for a breaking change, let's avoid it and just make sure v15 is supported. |
Yeah I think so. Keep devDep as-is so we don't accidentally start relying on a Nx 15 feature without realizing it. |
@escapedcat @Phault Ok ! Agree ! I have reverted changes and just added the 15.0.0 as peerDependency (together with 14.0.0). |
Thanks! Creating a release now. |
Expected Behavior
Using config-nx-scopes should be compatible with Nx 15, without installing with
--legacy-peer-deps
flag.Current Behavior
Usage with Nx 15 requires using
npm install --legacy-peer-deps
, but otherwise works fine.Affected packages
Possible Solution
Update the Nx version range in package.json to
nx: "^14.0.0 || ^15.0.0"
in peerDepsContext
No response
The text was updated successfully, but these errors were encountered: