Skip to content

Package distributions are not licensed #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
honzajavorek opened this issue Aug 30, 2018 · 3 comments
Closed

Package distributions are not licensed #426

honzajavorek opened this issue Aug 30, 2018 · 3 comments

Comments

@honzajavorek
Copy link
Contributor

Hi @marionebl 👋 The code of the commitlint monorepo is licensed under MIT, and that's great. But according to MIT, the license text needs to be attached everywhere:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

The npm packages as they're published and distributed, do not comply with this as they do not contain the license files. Effectively, without the full license text they're proprietary code and cannot be used by anyone who cares about licenses. The SPDX identifier in the package.json is not satisfactory (not only) for the reasons mentioned above. There are two solutions to this:

  1. Upgrade to Lerna@3, as it has the licensing built-in now
  2. Copy & paste the root license to all projects in the packages directory, so it gets picked up by npm during publishing, and to re-publish all of them with a new patch version.

For more information, see lerna/lerna#1465 (comment), babel/babel#7308 (comment), babel/babel#8409 (comment).

@marionebl
Copy link
Contributor

Thanks for bringing this to my attention, will create a properly licensed release right away.

@marionebl
Copy link
Contributor

Fixed via 7.1.2 🎉

@honzajavorek
Copy link
Contributor Author

@marionebl Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants