Make the --github-auth flag work for extensions

[code-asher]

I was hoping the existing --github-auth flag would just work but it did not. Extensions seems to use a completely different credential entry for some reason so I have it inserting one that matches. I tested the pull request extension and GitLens.

There will be a companion PR shortly to make this work with code-server.

I am very unsure as to whether this is the right way to handle it.

[jsjoeio]

This are the kind of nuance things where I think, "How did Asher figure this out? 😅"

Nice work though! I appreciate the set of comments and how small this change is. Can't wait for patches.

[jsjoeio]

Was this intentional?

[code-asher]

Ah it kind of was intentional in that I did see my editor had done this but for some reason it did not occur to me to skip committing this. Gonna remove to not needlessly increase the patch size.

[code-asher]

Actually looks like it is our own comment so I will go ahead and leave it.

[jsjoeio]

❓ How come they have to be duplicated like this? I would think it would be enough to do:

Suggested change

	scopes: [['read:user', 'user:email', 'repo'], ['user:email'], ['repo']]
	scopes: [['read:user'], ['user:email'], ['repo']]

[code-asher]

Yup, I thought so too but the scopes have to match exactly. So if an extension wants ['repo'] but the token offers both ['repo', 'read:user'] then it will not match.

You can see here they do a strict equals on the scopes array:

vscode/extensions/github-authentication/src/github.ts

Lines 73 to 75 in 676edaa

	const finalSessions = scopes
	? sessions.filter(session => arrayEquals([...session.scopes].sort(), scopes.sort()))
	: sessions;

It does feel like a bug so maybe we should patch this instead but idk.

[jsjoeio]

AH...that make sense. Thanks for explaining. When we get to patches, I will see if it's a bug and we can raise upstream.