Skip to content

feat: github-auth flag #4926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 2, 2022
Merged

feat: github-auth flag #4926

merged 3 commits into from
Mar 2, 2022

Conversation

code-asher
Copy link
Member

This will allow injecting credentials into code-server if you already
have them.

Blocked by coder/vscode#48

@code-asher code-asher requested a review from a team March 1, 2022 00:47
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #4926 (1682738) into main (3f3a489) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4926      +/-   ##
==========================================
+ Coverage   70.02%   70.16%   +0.14%     
==========================================
  Files          29       29              
  Lines        1658     1666       +8     
  Branches      364      369       +5     
==========================================
+ Hits         1161     1169       +8     
  Misses        423      423              
  Partials       74       74              
Impacted Files Coverage Δ
src/node/cli.ts 84.81% <100.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f3a489...1682738. Read the comment docs.

Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! Nice addition + tests.

This will allow injecting credentials into code-server if you already
have them.
Contains the GitHub auth changes.
@code-asher code-asher merged commit 0e78a14 into coder:main Mar 2, 2022
@code-asher code-asher deleted the github-auth-flag branch March 2, 2022 20:02
TinLe pushed a commit to TinLe/code-server that referenced this pull request Apr 23, 2022
* feat: github-auth flag

This will allow injecting credentials into code-server if you already
have them.

* Update Code

Contains the GitHub auth changes.

* Add e2e test for GitHub token
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants