Skip to content

Restore socket write patch #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 23, 2021
Merged

Restore socket write patch #33

merged 2 commits into from
Dec 23, 2021

Conversation

code-asher
Copy link
Member

This is for coder/code-server#4620.

@code-asher
Remove unused patch
aa8083f
@code-asher
Restore socket write patch
e715061 
This allows external processes to read the socket or pipe and open files
in VS Code.
@code-asher code-asher requested a review from jsjoeio December 21, 2021 21:32
jsjoeio
jsjoeio approved these changes Dec 23, 2021
View reviewed changes
Copy link

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused patch

We should celebrate this 🎉 I hope we can do more of this in 2022.

@code-asher code-asher merged commit acfcdb5 into coder:main Dec 23, 2021
@code-asher code-asher deleted the open-in branch December 23, 2021 18:18
@jsjoeio jsjoeio mentioned this pull request Jan 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@code-asher @jsjoeio